Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs-minor-mode not enabled #13

Closed
abradd opened this issue Dec 28, 2023 · 1 comment · Fixed by #14
Closed

hs-minor-mode not enabled #13

abradd opened this issue Dec 28, 2023 · 1 comment · Fixed by #14
Labels
bug Something isn't working

Comments

@abradd
Copy link
Contributor

abradd commented Dec 28, 2023

hideshow functionality doesn't work when enabled in verilog-ext-feature-list because hs-minor-mode is not enabled.

I'm not sure if the plan was to enable it though verilog-ext-hs-setup or have the user setup the appropriate hook. I couldn't find the relevant info in the docs or code.

Not difficult to resolve for the user, but probably best to have the enablement method documented.

@gmlarumbe
Copy link
Owner

Hi @abradd ,

Thanks for reporting the issue and sorry for the late reply.

I guess that the thing that makes more sense to me is to enable it inside verilog-ext-hs-setup as you pointed out.

If you have already made this change, tested it and everything works fine I would be glad to merge a PR if you create one. Otherwise I will add it in upcoming commits when I have some time.

Thanks a lot!

@gmlarumbe gmlarumbe added the bug Something isn't working label Jan 11, 2024
@gmlarumbe gmlarumbe linked a pull request Jan 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants