Generic Dropdowns

[cconard96]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-

Intended to be integrated with custom fields for generic assets in a future PR.
PR also generalizes the generic asset code to de-duplicate the work between generic assets and generic dropdowns.

Generic dropdowns may optionally be "tree" dropdowns instead of flat ones. This can be changed at any time. When not in tree mode, the items are added at level 0 with the complete name set properly as if they were root items. The base class switches between CommonDropdown and CommonTreeDropdown depending on the value of is_tree in the definition.

Being based on the standard dropdown classes, these custom ones are obviously translatable in the same way.

[orthagh]

I wanted to test this one as well but as we (once again) are late on review, I thikg it's not up to date with the last evolution of generic routes for dropdown (#17454), no?

[cconard96]

I wanted to test this one as well but as we (once again) are late on review, I thikg it's not up to date with the last evolution of generic routes for dropdown (#17454), no?

I think it needs a new route. Custom Asset types and models aren't handled by the new controller either.

[cedric-anne]

I wanted to test this one as well but as we (once again) are late on review, I thikg it's not up to date with the last evolution of generic routes for dropdown (#17454), no?

I think it needs a new route. Custom Asset types and models aren't handled by the new controller either.

They are mapped with the generic dropdown controllers here:

glpi/src/Glpi/Http/LegacyDropdownRouteListener.php

Lines 87 to 93 in 22df3fd

	if ($asset_model_class = $this->findAssetModelclass($request)) {
	return $this->normalizeClass($asset_model_class);
	}
	if ($asset_type_class = $this->findAssetTypeclass($request)) {
	return $this->normalizeClass($asset_type_class);
	}

[cedric-anne]

I made some changes. Most important is that all custom dropdown are tree dropdowns, as it permits to simplify the code. I validated this change with @orthagh.

I did not had time to pass the whole test suite. If tests fails, I will fix them.

[cconard96]

Most important is that all custom dropdown are tree dropdowns

Disagree with that change but not willing to argue. Will wait and see if any users provide feedback about that forced behavior.