Many fixes:

 - Mutualize some code
 - Extends CommonTreeDropdown everytime
 - Put back `getAssetClassName()` to reduce diff
 - Add default SO
 - ...

.phpstan-baseline.php

@@ -1923,22 +1923,10 @@
 ];
 $ignoreErrors[] = [
 	// identifier: return.type
-	'message' => '#^Method Glpi\\\\Asset\\\\Asset\\:\\:getById\\(\\) should return static\\(Glpi\\\\Asset\\\\Asset\\)\\|false but returns Glpi\\\\Asset\\\\Asset\\.$#',
+	'message' => '#^Method Glpi\\\\Asset\\\\Asset\\:\\:getById\\(\\) should return static\\(Glpi\\\\Asset\\\\Asset\\)\\|false but returns object\\.$#',
 	'count' => 1,
 	'path' => __DIR__ . '/src/Glpi/Asset/Asset.php',
 ];
-$ignoreErrors[] = [
-	// identifier: parameter.notFound
-	'message' => '#^PHPDoc tag @param references unknown parameter\\: \\$definition$#',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Glpi/Asset/AssetDefinition.php',
-];
-$ignoreErrors[] = [
-	// identifier: parameter.notFound
-	'message' => '#^PHPDoc tag @param references unknown parameter\\: \\$profiles$#',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Glpi/Asset/AssetDefinition.php',
-];
 $ignoreErrors[] = [
 	// identifier: return.type
 	'message' => '#^Method Glpi\\\\Asset\\\\AssetModel\\:\\:getById\\(\\) should return static\\(Glpi\\\\Asset\\\\AssetModel\\)\\|false but returns Glpi\\\\Asset\\\\AssetModel\\.$#',
@@ -2275,6 +2263,12 @@
 	'count' => 1,
 	'path' => __DIR__ . '/src/Glpi/Dashboard/Provider.php',
 ];
+$ignoreErrors[] = [
+	// identifier: return.type
+	'message' => '#^Method Glpi\\\\Dropdown\\\\Dropdown\\:\\:getById\\(\\) should return static\\(Glpi\\\\Dropdown\\\\Dropdown\\)\\|false but returns object\\.$#',
+	'count' => 1,
+	'path' => __DIR__ . '/src/Glpi/Dropdown/Dropdown.php',
+];
 $ignoreErrors[] = [
 	// identifier: method.nonObject
 	'message' => '#^Cannot call method getItem\\(\\) on CommonDBTM\\|false\\.$#',

composer.json

@@ -167,7 +167,7 @@
         "psr-4": {
             "Glpi\\Tools\\": "tools/src/",
             "Glpi\\Tests\\": "tests/src/",
-            "Glpi\\PHPUNit\\Tests\\": "phpunit/src/"
+            "Glpi\\PHPUnit\\Tests\\": "phpunit/src/"
         },
         "files": ["tests/src/autoload/functions.php"]
     },

dependency_injection/legacyConfigProviders.php

@@ -35,8 +35,6 @@
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Glpi\Config\LegacyConfigProviderInterface;
-use Glpi\Config\LegacyConfigurators\AssetsAutoloader;
-use Glpi\Config\LegacyConfigurators\AssetsBootstrap;
 use Glpi\Config\LegacyConfigurators\CleanPHPSelfParam;
 use Glpi\Config\LegacyConfigurators\ConfigRest;
 use Glpi\Config\LegacyConfigurators\CustomObjectsAutoloader;

front/asset/asset.form.php

@@ -50,7 +50,7 @@
 } else {
     $definition = new AssetDefinition();
     $classname  = array_key_exists('class', $_GET) && $definition->getFromDBBySystemName((string)$_GET['class'])
-        ? $definition->getCustomObjectClassName()
+        ? $definition->getAssetClassName()
         : null;
     $asset      = $classname !== null && class_exists($classname)
         ? new $classname()

front/asset/asset.php

@@ -39,7 +39,7 @@
 
 $definition = new AssetDefinition();
 $classname  = array_key_exists('class', $_GET) && $definition->getFromDBBySystemName((string)$_GET['class'])
-    ? $definition->getCustomObjectClassName()
+    ? $definition->getAssetClassName()
     : null;
 
 if ($classname === null || !class_exists($classname)) {

install/migrations/update_10.0.x_to_11.0.0/dropdowns.php

@@ -34,7 +34,7 @@
 
 /**
  * @var array $ADDTODISPLAYPREF
- * @var DB $DB
+ * @var DBmysql $DB
  * @var Migration $migration
  */
 
@@ -52,7 +52,6 @@
             `is_active` tinyint NOT NULL DEFAULT '0',
             `profiles` JSON NOT NULL,
             `translations` JSON NOT NULL,
-            `is_tree` tinyint NOT NULL DEFAULT '0',
             `date_creation` timestamp NULL DEFAULT NULL,
             `date_mod` timestamp NULL DEFAULT NULL,
             PRIMARY KEY (`id`),
@@ -69,7 +68,7 @@
     $query = <<<SQL
         CREATE TABLE `glpi_dropdowns_dropdowns` (
             `id` int {$default_key_sign} NOT NULL AUTO_INCREMENT,
-            `dropdowns_dropdowndefinitions_id` int unsigned NOT NULL,
+            `dropdowns_dropdowndefinitions_id` int {$default_key_sign} NOT NULL,
             `name` varchar(255) DEFAULT NULL,
             `comment` text,
             `entities_id` int {$default_key_sign} NOT NULL DEFAULT '0',

install/mysql/glpi-empty.sql

@@ -9953,7 +9953,6 @@ CREATE TABLE `glpi_dropdowns_dropdowndefinitions` (
   `is_active` tinyint NOT NULL DEFAULT '0',
   `profiles` JSON NOT NULL,
   `translations` JSON NOT NULL,
-  `is_tree` tinyint NOT NULL DEFAULT '0',
   `date_creation` timestamp NULL DEFAULT NULL,
   `date_mod` timestamp NULL DEFAULT NULL,
   PRIMARY KEY (`id`),

phpunit/DbTestCase.php

@@ -398,8 +398,8 @@ protected function initAssetDefinition(
         );
 
         // Clear definition cache
-        $rc = new ReflectionClass(\Glpi\Asset\AssetDefinitionManager::class);
-        $rc->getProperty('definitions_data')->setValue(\Glpi\Asset\AssetDefinitionManager::getInstance(), null);
+        $rc = new ReflectionClass(\Glpi\CustomObject\AbstractDefinitionManager::class);
+        $rc->getProperty('definitions_data')->setValue(\Glpi\Asset\AssetDefinitionManager::getInstance(), []);
 
         $manager = \Glpi\Asset\AssetDefinitionManager::getInstance();
         $this->callPrivateMethod($manager, 'loadConcreteClass', $definition);

phpunit/functional/SearchTest.php

@@ -4141,10 +4141,10 @@ protected function customAssetsProvider(): iterable
         $document_3 = $this->createTxtDocument();
 
         $definition_1  = $this->initAssetDefinition(capacities: [HasDocumentsCapacity::class]);
-        $asset_class_1 = $definition_1->getCustomObjectClassName();
+        $asset_class_1 = $definition_1->getAssetClassName();
 
         $definition_2  = $this->initAssetDefinition(capacities: [HasDocumentsCapacity::class]);
-        $asset_class_2 = $definition_2->getCustomObjectClassName();
+        $asset_class_2 = $definition_2->getAssetClassName();
 
         // Assets for first class
         $asset_1_1 = $this->createItem(