Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: undefined method tainted? when using Ruby v3.2.0 #859

Closed
3 of 4 tasks
nshki opened this issue Dec 25, 2022 · 2 comments · Fixed by #860
Closed
3 of 4 tasks

Error: undefined method tainted? when using Ruby v3.2.0 #859

nshki opened this issue Dec 25, 2022 · 2 comments · Fixed by #860

Comments

@nshki
Copy link

nshki commented Dec 25, 2022

Before submitting an issue, please be sure to

This issue affects

  • The site generated by GitHub Pages
  • Building sites locally

The GitHub Pages Gem is intended to help users replicate the GitHub Pages build environment locally. If your issue affects both the hosted version and the version previewed locally, you may be better suited reporting seeking support in other forums.

What did you do (e.g., steps to reproduce)

  1. Install Ruby v3.2.0 via rbenv with rbenv install 3.2.0.
  2. Set global Ruby version to v3.2.0 with rbenv global 3.2.0.
  3. bundle install in the Jekyll repo.
  4. Try starting a dev server with bundle exec jekyll serve.

What did you expect to happen?

The Jekyll project to run on localhost:4000.

What happened instead?

The following error was thrown in the terminal:

  Liquid Exception: undefined method `tainted?' for "2013-12-27T00:00:00-08:00":String in /_layouts/post.html                                                                          
jekyll 3.9.2 | Error:  undefined method `tainted?' for "2013-12-27T00:00:00-08:00":String                                                                                              
/Users/nshki/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/liquid-4.0.3/lib/liquid/variable.rb:124:in `taint_check': undefined method `tainted?' for "2013-12-27T00:00:00-08:00":String (NoMethodError)
@parkr
Copy link
Contributor

parkr commented Dec 25, 2022

Liquid 4 is not compatible with Ruby 3.2. Shopify/liquid#1625 (comment)

@parkr
Copy link
Contributor

parkr commented Jan 11, 2023

Liquid is updated. Upgrade to v4.0.4.

gradybarrett pushed a commit to gradybarrett/pages-gem that referenced this issue Jan 12, 2023
Ruby 3.2 removed the "tainted" interface, which liquid
>=4.0.3 still uses. Liquid 4.0.4 removes references to this
interface that it works with Ruby 3.2.

Closes github#859.
gradybarrett pushed a commit to gradybarrett/pages-gem that referenced this issue Jan 25, 2023
Ruby 3.2 removed the "tainted" interface, which liquid
>=4.0.3 still uses. Liquid 4.0.4 removes references to this
interface that it works with Ruby 3.2.

Closes github#859.
davidlj95 added a commit to davidlj95/website that referenced this issue Aug 9, 2023
kzu added a commit to devlooped/TableStorage that referenced this issue Jul 9, 2024
kzu added a commit to clarius/pages that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants