Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting Ruby 3.2 support to 4.x series #1664

Closed
janko opened this issue Dec 28, 2022 · 8 comments
Closed

Backporting Ruby 3.2 support to 4.x series #1664

janko opened this issue Dec 28, 2022 · 8 comments

Comments

@janko
Copy link

janko commented Dec 28, 2022

It seems that Jekyll still has Liquid locked to versions 4.x, and it doesn't seem like this will change soon. It would be great if Ruby 3.2 support was backported to Liquid 4.x, as that should hopefully allow current Jekyll to run on Ruby 3.2 🙏🏻

@parkr
Copy link
Contributor

parkr commented Dec 29, 2022

This would be a fix for the largest number of people I think, since anything we do with Jekyll would require users to upgrade existing installations. An easier sell to GitHub Pages, too, I bet.

@parkr
Copy link
Contributor

parkr commented Dec 29, 2022

Cc github/pages-gem#859

@parkr
Copy link
Contributor

parkr commented Jan 9, 2023

@dylanahsmith Hey! I was looking at the Liquid 4.0.3 code and noticed that there's a taint_mode. Would you be interested in adding a quick patch for Liquid 4 which offers taint_mode = :off? or taint_mode = :disabled? This would disable all calls to tained? and untaint.

@markets
Copy link

markets commented Jan 10, 2023

That would be amazing! I'm also having problems running Jekyll (v3 and v4) with Ruby 3.2 (it goes fine with Ruby 3.3.0-dev btw). You can see the whole matrix here: markets/jekyll-timeago#36.

Captura de Pantalla 2023-01-10 a las 19 20 02

@dylanahsmith
Copy link
Contributor

I've opened #1668 to backport ruby 3.2 support. However, we should really implement #1566 to get jekyll on liquid v5.

@dylanahsmith
Copy link
Contributor

Fixed by #1668, and I've released liquid version 4.0.4 and liquid-c version 4.0.1

@janko
Copy link
Author

janko commented Jan 11, 2023

Thank you for the fix, I really appreciate it! ❤️

@parkr
Copy link
Contributor

parkr commented Jan 11, 2023

Hugely appreciated, Dylan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants