-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md #31191
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@charleskimbac Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Hi @charleskimbac, thanks so much for opening this. This is interesting because we've only just changed the direction of the slashes based on previous feedback. It was my understanding that the direction of the slashes wouldn't actually matter to Powershell, which can cope with both. To confirm this, I created a fresh Windows 11 VM to test. It looks like
The same is true with I'm curious if the errors you're seeing are due to a different version of We can only really support a default installation but, as both slash-directions work on a default install, and it looks like switching back to forward slashes will help some folks such as yourself, let's do that! I'll approve this and get your changes merged in. Thank you! ✨✨✨✨
Did you run |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Hey @stevecat so I want to start by saying that I only have a bare knowledge of all of this, so apologies if I say/do something incorrectly. |
Ooh, thanks @charleskimbac! I'm experimenting with this and it appears that running the Launching I'm currently working on a project to revamp our SSH docs, and am paying extra attention to the Windows procedures. I'll work with our team to decide on the best option for that second step; either sticking with Powershell or adding the eval command. |
Why:
Fix some typos regarding what is actually shown in the terminal, and also fix a command which previously didn't work.
"ssh-add c:\Users\YOU.ssh\id_ed25519" (with backslashes) leads to error "c:UsersYOU.sshid_ed25519: No such file or directory".
Notes:
I had to run "eval `ssh-agent -s`" in bash before being able to run ssh-add (link), should maybe add this to the docs.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.