-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect windows syntax & instructions fixed #30855
Conversation
Some of the syntax was incorrect in the instructions regarding the path to your ssh key on windows (/ used instead of \, no : after drive label) Also corrected an error where the guide suggested to use CMD instead of PowerShell for commands that only work in PowerShell.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Vortun Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Hey @Vortun! Thanks for opening this ✨ I just tested this on my own Windows machine and the prompt was a mind-bending combination of both slashes 😅
Did you test this yourself and see I'm curious about the first Your other change, removing the mention of command prompt, looks great. Once we've figured this out, I'll approve and we can get this merged! |
Fixed a couple leftover frontslashes from previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that, @Vortun! ✨
Looking around, I think my Powershell is just spectacularly misconfigured, it looks like the format you're seeing is standard.
I'll get this merged now! Thanks again for contributing to our docs! 🎉 ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Some of the syntax was incorrect in the instructions regarding the path to your ssh key on windows (/ used instead of , no : after drive label)
Also corrected an error where the guide suggested to use CMD instead of PowerShell for commands that only work in PowerShell.
Why: Some of the information regarding SSH connection was incorrect on Windows.
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs): Frontslashes changed to backslashes, colon added after drive name, reference to CMD removed in section with PowerShell unique commands.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.