Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark deno.lock as generated #6885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark deno.lock as generated #6885

wants to merge 1 commit into from

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jun 13, 2024 •
edited
Loading

Mark deno.lock files as generated by the deno cli.

Closes: #6882

Description

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

I'm not sure where to place a deno.lock for tests. I greped around, but I couldn't find a Dummy/ folder.

@lishaduck lishaduck requested a review from a team as a code owner June 13, 2024 22:42
@lishaduck lishaduck marked this pull request as draft June 14, 2024 02:07
@lildude
Copy link
Member

lildude commented Jun 14, 2024

I'm not sure where to place a deno.lock for tests. I greped around, but I couldn't find a Dummy/ folder.

We already have one: https://github.com/github-linguist/linguist/blob/master/samples/JSON/filenames/deno.lock

#6783 is a recent PR you can copy.

@lildude lildude changed the title feat: mark deno lockfiles as generated Mark deno.lock as generated Jun 14, 2024
@lishaduck lishaduck marked this pull request as ready for review June 14, 2024 14:28
lildude
lildude approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lishaduck @lildude