Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno Lockfiles #6882

Open
lishaduck opened this issue Jun 13, 2024 · 2 comments
Open

Deno Lockfiles #6882

lishaduck opened this issue Jun 13, 2024 · 2 comments

Comments

@lishaduck
Copy link
Contributor

Describe the enhancement

I noticed that deno.lock isn't marked as generated. As I looked at the source code for marking things as generated, I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock?
Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

@lildude
Copy link
Member

lildude commented Jun 13, 2024

I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock?

Yes, because not everyone wants their lock files marked as generated as is the case with yarn.lock following the discussion in #4348

Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

We're happy to accept a PR, but keep in mind the yarn community's decision; maybe the demo community expects the same?

@lishaduck
Copy link
Contributor Author

I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock?

Yes, because not everyone wants their lock files marked as generated as is the case with yarn.lock following the discussion in #4348

Ah, yes. I recall seeing that. That makes a lot more sense now.

Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

We're happy to accept a PR, but keep in mind the yarn community's decision; maybe the demo community expects the same?

Given the differences between PnP and HTTPS imports, and particularly that much of the ecosystem doesn't use lockfiles (as esm.sh messes them up), I don't think that Yarn's security argument applies here.

@lishaduck lishaduck changed the title Lock files Deno Lockfiles Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants