Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Glimmer TS language #6680

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Add Glimmer TS language #6680

merged 10 commits into from
Mar 8, 2024

Conversation

gilest
Copy link
Contributor

@gilest gilest commented Jan 17, 2024

Description

Adds support for TypeScript-flavoured Glimmer.js which will be the component authoring format of the next Edition of Ember.js.

Checklist:

@gilest gilest requested a review from a team as a code owner January 17, 2024 04:09
@gilest
Copy link
Contributor Author

gilest commented Jan 17, 2024

CI is failing because the vscode-vba repo has been removed from GitHub

@lildude
Copy link
Member

lildude commented Jan 17, 2024

All should be good now I've merged #6678

@deanylev
Copy link

Is this able to be merged? Reviewing our gts files in PRs is a nightmare at the moment 🙏

@gilest
Copy link
Contributor Author

gilest commented Jan 30, 2024

Is this able to be merged? Reviewing our gts files in PRs is a nightmare at the moment 🙏

Appreciate your anticipation @deanylev

According to the Lingust docs

Changes to Linguist will only appear on GitHub when a new Linguist release is made and this is deployed to GitHub.com. There is no set release timeframe, but the intention is at least once every three-to-four months...

So even if this PR is merged, we'll be waiting for the next Lingust release which may be in March/April 🙂

@Techn1x
Copy link

Techn1x commented Feb 8, 2024

Looking forward to this as well. For what it's worth, we have 300+ GTS files in a private repo.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit dabba4a Mar 8, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants