Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change VBA grammar source #6678

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Change VBA grammar source #6678

merged 4 commits into from
Jan 17, 2024

Conversation

serkonda7
Copy link
Contributor

@serkonda7 serkonda7 commented Jan 15, 2024 •
edited by lildude
Loading

Followup to #6677
Remove the intermediary step of transpiling to json

Description

Checklist:

@serkonda7 serkonda7 requested a review from a team as a code owner January 15, 2024 17:08
@serkonda7
Copy link
Contributor Author

@lildude this should be better now

@lildude lildude changed the title vba: change source from vscode-vba-json to vscode-vba Change VBA grammar source Jan 15, 2024
lildude
lildude approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude
Copy link
Member

lildude commented Jan 17, 2024

Oooof, the missing repo is now causing other PRs to fail so I'm going to merge this now. It won't be used on GitHub.com until the next release.

@lildude lildude added this pull request to the merge queue Jan 17, 2024
Merged via the queue into github-linguist:master with commit 559a642 Jan 17, 2024
5 checks passed
This was referenced Jan 17, 2024
Merged
Merged
@serkonda7
Copy link
Contributor Author

Sorry for breaking your CI.

@github-linguist github-linguist deleted a comment from cm9255176 Apr 30, 2024
@github-linguist github-linguist deleted a comment from cm9255176 Apr 30, 2024
@github-linguist github-linguist deleted a comment from cm9255176 Apr 30, 2024
@github-linguist github-linguist deleted a comment from cm9255176 Apr 30, 2024
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serkonda7 @lildude