Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .txx extension to C++ #6380

Merged
merged 3 commits into from
May 30, 2023
Merged

Add .txx extension to C++ #6380

merged 3 commits into from
May 30, 2023

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented Apr 17, 2023

Include support for the ".txx" file extension, which has been commonly used for C++ template implementation across various build systems. build2/bdep#5

Checklist:

In C++, the file extension ".txx" is frequently utilized for  C++ template implementation.
@wroyca wroyca requested a review from a team as a code owner April 17, 2023 20:04
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one to three of the most representative samples you have referenced to the C++ samples directory… we need the actual files to train the classifier, not just the links 😉

@wroyca
Copy link
Contributor Author

wroyca commented Apr 18, 2023

Please add one to three of the most representative samples you have referenced to the C++ samples directory… we need the actual files to train the classifier, not just the links wink

Oops, done. Thank! 🚀

@wroyca wroyca requested a review from lildude April 18, 2023 11:41
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@Alhadis Alhadis changed the title Add '.txx' extension to C++ Add .txx extension to C++ Apr 25, 2023
@lildude lildude requested a review from a team as a code owner May 30, 2023 09:13
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit c9898bc May 30, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants