Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linguist-language=C++ to .gitattributes #5

Closed
wants to merge 1 commit into from
Closed

Add linguist-language=C++ to .gitattributes #5

wants to merge 1 commit into from

Conversation

wroyca
Copy link

@wroyca wroyca commented Apr 14, 2023

This PR enhances the .gitattributes generation code by adding the linguist-language=C++ attribute. This attribute ensures that Git repository hosting platforms correctly recognize txx and ixx file types, which are not detected as C++ by default.

@boris-kolpackov
Copy link
Member

Background: this appears to be GitHub-only, based on their https://github.com/github/linguist Ruby library.

Maybe we can also add this for our buildfiles (which currently seem to be treated as Ruby).

@wroyca
Copy link
Author

wroyca commented Apr 17, 2023

Background: this appears to be GitHub-only, based on their https://github.com/github/linguist Ruby library.

Maybe we can also add this for our buildfiles (which currently seem to be treated as Ruby).

This is also used by GitLab https://gitlab.com/gitlab-org/linguist and others~ 🙂

@wroyca
Copy link
Author

wroyca commented Apr 17, 2023

Maybe we can also add this for our buildfiles (which currently seem to be treated as Ruby).

We can use linguist-language=Makefile for build2 related files. You may add new commits to my branch if you feel like it's something we should have - or just give me a ping, and I'll take a look at it when I'm available! 🚀

@wroyca
Copy link
Author

wroyca commented May 6, 2023

Closing as this will be merged with github-linguist next release.

@wroyca wroyca closed this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants