Add .frm and .cls extensions to VB6 #6155

DecimalTurn · 2022-11-04T05:04:06Z

Following up on discussions in issue #5824, I'm proposing to add .frm and .cls as extensions for VB6 with heuristics to distinguish it from VBA.

Description

The heuristics added to distinguish VBA from VB6 were suggested by @XusinboyBekchanov :

frm
VBA:

VB6:
cls
VB6 :

VBA : If the pattern above doesn't match, we default to VBA.

The key of these are based on the way the VB6 and VBA IDEs encode information at the top of the file when exporting the forms or class module as text files. From what I know, there isn't really a good reason for developers to alter this information as this could cause issues when trying to import back the text file into their IDE. Hence, those differences should be sufficiently reliable to distinguish between VBA and VB6.

PS : Due to the way I pulled changes from master, this pull request appears to contain more commits that it really does. Commits before 2d3547 can be ignored.

Checklist:

VB6

I am associating a language with a new file extension.
- The new extension is used in hundreds of repositories on GitHub.com
  - Search results for each extension:
    - https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3Afrm+"Begin+VB.form"+NOT+nothack
    - https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3Acls+Persistable+NOT+nothack
- I have included a real-world usage sample for all extensions added in this PR:
  - Sample source(s):
    - ~~https://github.com/raw/dragokas/hijackthis/devel/src/frmMain.frm~~
    - https://github.com/raw/dragokas/hijackthis/devel/src/frmProcMan.frm (GPL-2.0 license)
    - https://github.com/raw/tannerhelland/PhotoDemon/main/Forms/Adjustments_BlackAndWhite.frm (BSD-icense)
    - https://github.com/raw/dragokas/hijackthis/devel/src/clsDataPack.cls (GPL-2.0 license)
    - https://github.com/raw/tannerhelland/PhotoDemon/main/Classes/clsMenuImage.cls (BSD-icense)
  - Sample license(s): Specified after the link
- I have included a change to the heuristics to distinguish my language from others using the same extension.

VBA

I am fixing a misclassified language
- I have included a new sample for the misclassified language:
  - Sample source(s):
  - Sample license(s): Specified after the link
- I have included a change to the heuristics to distinguish my language from others using the same extension.

Adding the VB6 language and removing it as an alias of VBA.

No samples for .vb6 found on GitHub

In response to requested change: github-linguist#6124 (comment)

Removing frx since it's a binary data file instead of code.

lildude

Why are you removing the samples/VBA/cApplication.cls sample? We don't remove samples if we can avoid it.

samples/Visual Basic 6.0/frmMain.frm is massive. Please replace it with a smaller sample.

I also recommend adding two distinct samples for each of these extensions to help the classifier in the event things slip through the heuristics.

lib/linguist/languages.yml

DecimalTurn · 2022-11-04T17:16:58Z

Why are you removing the samples/VBA/cApplication.cls sample? We don't remove samples if we can avoid it.

Because this sample is a VB6 sample (based on the heuristics this PR introduced). My understanding is that in the PR #4725, where this sample was added, the intention was to put VBA and VB6 under the same language "VBA/VB6", but when it changed to just VBA, the sample for VB6 was left there by mistake.

And the reason why I didn't add it to the VB6 samples is because I couldn't find its origin on GitHub and I wanted to add a sample from a popular project such as hijackthis.

samples/Visual Basic 6.0/frmMain.frm is massive. Please replace it with a smaller sample.

Sure. Will do.

I also recommend adding two distinct samples for each of these extensions to help the classifier in the event things slip through the heuristics.

Sounds good. Should I add back cApplication.cls as a VB6 sample or should I add another one instead to avoid confusion?

DecimalTurn · 2022-11-04T17:22:07Z

Regarding the .bas extension, I've intentionally kept it out of this PR since I'm still not sure about the heuristic for it when it's time to distinguish between VBA and VB6.

lildude · 2022-11-05T13:48:10Z

Because this sample is a VB6 sample (based on the heuristics this PR introduced). My understanding is that in the PR #4725, where this sample was added, the intention was to put VBA and VB6 under the same language "VBA/VB6", but when it changed to just VBA, the sample for VB6 was left there by mistake.

Cool. In that case, please move it rather than remove it. We've already approved its inclusion so there's no need to find the source etc.

You can still add another if it'll help the classifier which is falling on this extension.

DecimalTurn · 2022-11-09T03:20:58Z

The Classifier test didn't succeed with 100%, but it's already better:

.cls (5/6)
VBA/GridCoord.cls BAD ❌(Visual Basic 6.0)
VBA/WorkbookReporter.cls ✅
VBA/dictionary.cls ✅
Visual Basic 6.0/cApplication.cls ✅
Visual Basic 6.0/clsDataPack.cls ✅
Visual Basic 6.0/clsMenuImage.cls ✅

.frm (4/4)
VBA/frmConvert.frm ✅
VBA/stdSaveHandler.frm ✅
Visual Basic 6.0/Adjustments_BlackAndWhite.frm ✅
Visual Basic 6.0/frmProcMan.frm ✅

Considering that the heuristics should be pretty reliable, can this suffice?

lildude · 2022-11-09T11:45:07Z

The Classifier test didn't succeed with 100%, but it's already

It needs to. Try removing the sample or adding another sample.

DecimalTurn · 2022-11-09T18:38:20Z

Alright, I've switched the problematic sample with another one from the same project. Now, all the tests are passing and I updated the PR description at the top with the correct samples.
Looks like we are good to go unless there is something I missed.

lib/linguist/heuristics.yml

@Alhadis

Apply regex simplification suggested by @Alhadis Co-authored-by: John Gardner <gardnerjohng@gmail.com>

"general newline" https://github.com/kkos/oniguruma/blob/master/doc/SYNTAX.md#23-onig_syn_op2_esc_capital_r_general_newline-enable-r Introduced by github-linguist/linguist#6155 (comment)

DecimalTurn and others added 20 commits October 17, 2022 21:17

Add VB6

0d61271

Adding the VB6 language and removing it as an alias of VBA.

Remove .vb6 extension

aa71044

No samples for .vb6 found on GitHub

Add samples

6057834

Update ids

bd86e5a

Change language name and adjust aliases

d443d52

In response to requested change: github-linguist#6124 (comment)

Change .dsr to .Dsr

48b8212

Add addtionnal sample for .Dsr

1ab9689

Change folder name

fa71f01

Fix order

d9806b9

Add missing VB6 line

c265077

Merge branch 'github:master' into master

2d35478

Remove frx extension

c85e552

Removing frx since it's a binary data file instead of code.

Add .cls and .frm to VB6

d1b56be

Add heuristics for VB6 and VBA

f5d413f

Add samples

11732dc

Add tests and remove erroneous sample

a57a066

Reorder extensions

928f40f

Add extra VBA sample

16088f9

Add frm VBA sample

960b99e

Remove duplicate row

311000a

DecimalTurn requested a review from a team as a code owner November 4, 2022 05:04

lildude requested changes Nov 4, 2022

View reviewed changes

lib/linguist/languages.yml Show resolved Hide resolved

lib/linguist/languages.yml Show resolved Hide resolved

DecimalTurn added 2 commits November 8, 2022 21:50

Delete frmMain and add more samples

97c28c7

Add back cApplication.cls

dba304a

DecimalTurn requested a review from lildude November 9, 2022 03:21

Add back comment

560b48e

DecimalTurn added 2 commits November 9, 2022 13:01

Switch VBA .cls sample

440866e

Merge branch 'master' of https://github.com/DecimalTurn/linguist

d790d3f

lildude requested a review from Alhadis November 12, 2022 14:11

Alhadis requested changes Nov 12, 2022

View reviewed changes

lib/linguist/heuristics.yml Outdated Show resolved Hide resolved

DecimalTurn and others added 3 commits November 12, 2022 13:14

Update lib/linguist/heuristics.yml

34dc098

Apply regex simplification suggested by @Alhadis Co-authored-by: John Gardner <gardnerjohng@gmail.com>

Merge branch 'master' into master

eb4a64c

Merge branch 'master' into master

74b6b7a

Alhadis approved these changes Nov 14, 2022

View reviewed changes

lildude approved these changes Nov 14, 2022

View reviewed changes

lildude merged commit 7cb8f4a into github-linguist:master Nov 14, 2022

DecimalTurn mentioned this pull request Nov 17, 2022

Add language override for Linguist tannerhelland/PhotoDemon#457

Merged

bzz mentioned this pull request Mar 6, 2023

WIP add heuristic for unsupported regex syntax go-enry/go-enry#160

Closed

DecimalTurn mentioned this pull request Apr 2, 2023

Add .bas extension to VB6 and heuristics for VB6/VBA #6355

Merged

7 tasks

DecimalTurn mentioned this pull request May 23, 2023

Remove \R in VB6 heuristic #6427

Closed

github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .frm and .cls extensions to VB6 #6155

Add .frm and .cls extensions to VB6 #6155

DecimalTurn commented Nov 4, 2022 •

edited

Loading

lildude left a comment •

edited

Loading

DecimalTurn commented Nov 4, 2022 •

edited

Loading

DecimalTurn commented Nov 4, 2022

lildude commented Nov 5, 2022

DecimalTurn commented Nov 9, 2022 •

edited

Loading

lildude commented Nov 9, 2022

DecimalTurn commented Nov 9, 2022 •

edited

Loading

Add .frm and .cls extensions to VB6 #6155

Add .frm and .cls extensions to VB6 #6155

Conversation

DecimalTurn commented Nov 4, 2022 • edited Loading

Description

Checklist:

VB6

VBA

lildude left a comment • edited Loading

Choose a reason for hiding this comment

DecimalTurn commented Nov 4, 2022 • edited Loading

DecimalTurn commented Nov 4, 2022

lildude commented Nov 5, 2022

DecimalTurn commented Nov 9, 2022 • edited Loading

lildude commented Nov 9, 2022

DecimalTurn commented Nov 9, 2022 • edited Loading

DecimalTurn commented Nov 4, 2022 •

edited

Loading

lildude left a comment •

edited

Loading

DecimalTurn commented Nov 4, 2022 •

edited

Loading

DecimalTurn commented Nov 9, 2022 •

edited

Loading

DecimalTurn commented Nov 9, 2022 •

edited

Loading