Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Basic 6.0 as its own language #6124

Merged
merged 10 commits into from
Oct 20, 2022

Conversation

DecimalTurn
Copy link
Contributor

@DecimalTurn DecimalTurn commented Oct 18, 2022

Description

This pull request adds VB6 as its own language and removes the aliases for VBA that were related to VB6.
This PR aims at solving issue #5824 and takes major inspiration from PR #4725.

For the color, I went with a green close to the green from the VB6 logo.

The extensions provided aren't shared with any languages in languages.yml, so no additional grammar or heuristic is necessary. The VB.NET grammar should suffice for now as it was also the grammar used when adding VBA.

Checklist:

Adding the VB6 language and removing it as an alias of VBA.
No samples for .vb6 found on GitHub
@DecimalTurn DecimalTurn requested a review from a team as a code owner October 18, 2022 03:18
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@DecimalTurn
Copy link
Contributor Author

DecimalTurn commented Oct 19, 2022

And regarding the .Dsr sample, I was a little bit limited by the fact that a license is needed. The problem with the current sample is that it has no sub procedures defined in it. We only have designer metadata. This is representative of a good portion of .Dsr files, but for completeness, it might be useful to add another sample with a few sub procedure definitions.

@lildude lildude changed the title Add VB6 as its own language Add Visual Basic 6.0 as its own language Oct 20, 2022
@lildude lildude merged commit 2a01204 into github-linguist:master Oct 20, 2022
@DecimalTurn
Copy link
Contributor Author

Thanks @lildude!

@Gagniuc
Copy link

Gagniuc commented Oct 29, 2022

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?
If it doesn't, can you please make this possible? Because if you look at my own Visual Basic 6.0 projects, there are no ".ctl" or ".dsr" files at all. But all the Visual Basic 6.0 projects that I have seen so far have something in common: files with the extension ".vbp" and ".vbw". More than likely for this reason we do not see any change.

@lildude
Copy link
Member

lildude commented Oct 30, 2022

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?

No. You'll need to use a manual override. I see this has also been asked and answered in #5824

@Gagniuc
Copy link

Gagniuc commented Oct 30, 2022

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?

No. You'll need to use a manual override. I see this has also been asked and answered in #5824

Thanks for the replay. In my view it is not ok to use manual override for VB6 projects on GitHub. I'm personally curious how many VB6 projects are on GitHub. This language is among the most important languages produced by our civilization. I mean, there are new languages that no one has ever heard of that are listed by the linguist, while VB6 is not. VB6 was the most popular computer language in the world for a long time and today it is used by a large mass of scientists and engineers for prototyping projects. Recognizing the VB6 language by default is a decent thing to do on GitHub. I am certain in the end this will be resolved.

@lildude
Copy link
Member

lildude commented Oct 31, 2022

Recognizing the VB6 language by default is a decent thing to do on GitHub. I am certain in the end this will be resolved.

Indeed. As I mentioned in the issue, a heuristic would be needed to do this. Please feel free to submit a PR that implements such a heuristic.

Locking this as the discussion should be taking in place in issues now this PR has been merged.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants