Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic option-lists like .ackrc #6088

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Add support for generic option-lists like .ackrc #6088

merged 6 commits into from
Oct 19, 2022

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Sep 22, 2022

Description

This pull-request adds support for generic option-lists that use shell syntax for their contents:

# Comment
--key=value
--verbose
-f

Currently, this is limited to .ackrc files, but I suspect analogous formats might be added in future. Hence why I've named this language Option List instead of merely ackrc or something.

About .ackrc files

.ackrc is a configuration file read by ack(1) that has ~5,683 indexed results on GitHub, with a healthy ratio of users and repositories.

The dotless variant ackrc appears to have adequate distribution, with ~430 search results and an ostensibly healthy user/repo ratio. Code search currently makes it cumbersome to count the exact number of users, so @lildude will want to review the actual usage of ackrc files on GitHub.

Colour rationale

The colour I chose is a muted shade of the Shell language's colour (specifically, its saturation and brightness levels were halved). Since these option-lists are a "shade" of shell syntax, I figured the derivation was appropriate.

Shell: #89e051
Option List: #476732

Checklist:

  • I am adding a new language
    • The extension filename of the language is used in hundreds of repositories:
      Probably. I'll leave the census to @lildude. 😉 For now, a search for files named .ackrc tosses up ~5,683 results.
    • I have included a real-world usage sample.
    • I have included a syntax highlighting grammar
    • I have updated the heuristics

@Alhadis Alhadis requested a review from a team as a code owner September 22, 2022 02:48
@Alhadis
Copy link
Collaborator Author

Alhadis commented Sep 22, 2022

@lildude Don't worry, I haven't forgotten about Mermaid. 😜 Just had to scratch an itch or two with some simpler formats first. 😁

@Alhadis Alhadis merged commit 977f8cc into master Oct 19, 2022
@Alhadis Alhadis deleted the ackrc branch October 19, 2022 11:25
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants