Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocha.opts to option-list filenames #6140

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add mocha.opts to option-list filenames #6140

merged 1 commit into from
Oct 26, 2022

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Oct 26, 2022

Description

This PR adds mocha.opts to the list of filenames recognised as generic option-lists.

Ideally, this really should've been included in #6088, but because mocha.opts files have been deprecated by Mocha for some time, I blindly assumed they wouldn't meet the usage requirements (hence, I didn't think to check). However, a code search for path:**/mocha.opts yields ~9,200 results, which likely spans 200 unique users.

Checklist:

@Alhadis Alhadis requested a review from a team as a code owner October 26, 2022 10:03
@Alhadis Alhadis requested a review from lildude October 26, 2022 10:04
@Alhadis
Copy link
Collaborator Author

Alhadis commented Oct 26, 2022

@lildude Low-hanging fruit.

@Alhadis Alhadis merged commit daf01cb into master Oct 26, 2022
@Alhadis Alhadis deleted the mocha-opts branch October 26, 2022 14:20
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants