-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport bugfixes to v0.16 #3774
Conversation
I think this one should also go in here #3744 |
I also merged in this fix: |
* Always support 4x MSAA on GL * Update changelog
@@ -697,7 +697,7 @@ pub enum BindError { | |||
s1 = if *.actual >= 2 { "s" } else { "" }, | |||
)] | |||
MismatchedDynamicOffsetCount { | |||
group: u8, | |||
group: u32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oi, this is, technically, a semver breaking change.
I think we could validly argue that while it is breaking, no one is going to be looking at it, only calling Display::fmt.
Let's go ahead with it.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
Backports
u32
indices for bind group layouts everywhere #3743all of which are crash fixes without any apparent api breackage.
Testing
It compiles and the only thing conflicting was the changelog