web: use get_preferred_canvas_format() to fill SurfaceCapabilities
#3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
reviewed
May 3, 2023
Wumpf
approved these changes
May 3, 2023
jinleili
force-pushed
the
web_surface_preferred_format
branch
from
50d75f0
to
b9cff4f
Compare
cwfitzgerald
requested changes
Jun 22, 2023
jinleili
force-pushed
the
web_surface_preferred_format
branch
from
c3d8861
to
b17e692
Compare
cwfitzgerald
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
On the web, wgpu always prioritizes returning the
Bgra8Unormformat in theformatsfield ofSurfaceCapabilities, but this format is not supported on Android devices:Testing
Tested on Android Chrome Canary 115.0.5747.0 via https://jinleili.github.io/learn-wgpu-zh/simuverse