Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan Command pool optimization #3065

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Vulkan Command pool optimization #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88044d1
Command pool optimization
gents83 Oct 5, 2022
2fd46fa
Merge branch 'gfx-rs:master' into CommandPool-optimization
gents83 Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wgpu-hal/src/vulkan/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ impl crate::CommandEncoder<super::Api> for super::CommandEncoder {
let _ = self
.device
.raw
.reset_command_pool(self.raw, vk::CommandPoolResetFlags::RELEASE_RESOURCES);
.reset_command_pool(self.raw, vk::CommandPoolResetFlags::default());
}

unsafe fn transition_buffers<'a, T>(&mut self, barriers: T)
Expand Down
1 change: 1 addition & 0 deletions wgpu-hal/src/vulkan/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,7 @@ impl crate::Device<super::Api> for super::Device {
) -> Result<super::CommandEncoder, crate::DeviceError> {
let vk_info = vk::CommandPoolCreateInfo::builder()
.queue_family_index(desc.queue.family_index)
.flags(vk::CommandPoolCreateFlags::TRANSIENT)
.build();
let raw = self.shared.raw.create_command_pool(&vk_info, None)?;

Expand Down