Vulkan Command pool optimization #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at Vulkan Samples and other Vulkan materials even on mobile it seems that the right way to manage command pools in a transient way as they are used by wgpu should be enabling the right flag and resetting it without any flags.
Vulkan Samples:
https://github.com/KhronosGroup/Vulkan-Samples/blob/master/framework/core/command_pool.cpp
Arm Mobile developer:
https://arm-software.github.io/vulkan_best_practice_for_mobile_developers/samples/performance/command_buffer_usage/command_buffer_usage_tutorial.html
In my local profilings in my proto engine we're passing from around 9ms to around 800μs (more than 10x speedup)
No warning on leaks from validation layers is appearing in RenderDoc on my side too.