-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(django_admin): Disable django_admin on prod #52329
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52329 +/- ##
==========================================
- Coverage 79.32% 79.31% -0.01%
==========================================
Files 4907 4907
Lines 205595 205595
Branches 35148 35148
==========================================
- Hits 163081 163074 -7
- Misses 37534 37540 +6
- Partials 4980 4981 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, was that it? 😅
Can we have a smoke test somewhere so we know for sure it is fixed and will stay that way?
/gcbrun |
Seems to work, just tested this locally. Thanks @klboke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a smoke test somewhere so we know for sure it is fixed and will stay that way?
I think this is a nice thing to have but don't think we should block on this.
Let's get a review from the backend team as well. |
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list.
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Disable django_admin on prod ,fix #23742 , getsentry/self-hosted#1039
cc @BYK
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.