chore: Remove django.admin

We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list.
getsentry · Jul 11, 2023 · a9bb5f6 · a9bb5f6
1 parent 2349aaf
commit a9bb5f6
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 362 deletions.
diff --git a/src/sentry/admin.py b/src/sentry/admin.py
diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py
@@ -88,8 +88,6 @@ def env(
 
 DEBUG = IS_DEV
 
-ADMIN_ENABLED = DEBUG
-
 ADMINS = ()
 
 # Hosts that are considered in the same network (including VPNs).
@@ -358,7 +356,6 @@ def env(
 ]
 
 INSTALLED_APPS = (
-    "django.contrib.admin",
     "django.contrib.auth",
     "django.contrib.contenttypes",
     "django.contrib.messages",

diff --git a/src/sentry/conf/urls.py b/src/sentry/conf/urls.py
@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-from django.conf import settings
 from django.urls import URLPattern, URLResolver, re_path
 
 from sentry.web.frontend import csrf_failure
@@ -29,9 +28,4 @@
     ),
 ]
 
-if "django.contrib.admin" in settings.INSTALLED_APPS and settings.ADMIN_ENABLED:
-    from sentry import django_admin
-
-    urlpatterns += django_admin.urlpatterns
-
 urlpatterns += web_urlpatterns
diff --git a/src/sentry/django_admin.py b/src/sentry/django_admin.py
diff --git a/tests/sentry/integrations/utils/fixtures/sentry_files.json b/tests/sentry/integrations/utils/fixtures/sentry_files.json
@@ -912,7 +912,6 @@
     "src/sentry/discover/models.py",
     "src/sentry/discover/tasks.py",
     "src/sentry/discover/utils.py",
-    "src/sentry/django_admin.py",
     "src/sentry/event_manager.py",
     "src/sentry/eventstore/__init__.py",
     "src/sentry/eventstore/base.py",