Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(django): Disable admin on prod #23742

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(django): Disable admin on prod #23742

merged 1 commit into from
Feb 9, 2021

Conversation

BYK
Copy link
Member

@BYK BYK commented Feb 9, 2021

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, /manage/ doesn't really cover everything that /admin/ can do for on-premise users. I'm not sure if we want to entirely abandon /admin/ or have any thoughts whatsoever on better supporting /manage/. Neither of these are good and both need love to have a better on-premise experience imo.

@BYK BYK merged commit 66f0115 into master Feb 9, 2021
@BYK BYK deleted the byk/fix/disable-admin branch February 9, 2021 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
hubertdeng123 pushed a commit that referenced this pull request Jul 10, 2023
Disable django_admin on prod ,fix #23742 ,
getsentry/self-hosted#1039

cc @BYK 

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants