fix(sdk-crashes): Improve Cocoa crash detection #52119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a test case with frames from a real-world crash caused by our MetricKit integration. All data was anonymized. While adding the test case, a couple of problems surfaced that this PR addresses: 1. Correctly detect crashes from Swift files starting with SentryMX. 2. Correctly detect crashes from class extensions such as NSDate(SentryExtras). 3. Ignore in_app when detecting an SDK crash, as customers can change the in_app rules. Furthermore, if they use static linking for including Sentry Cocoa, Cocoa SDK frames can be marked as in_app. Instead, the algorithm only checks if frames are SDK frames or from system libraries.
github-actions
bot
added
the
Scope: Backend
philipphofmann
commented
Jul 4, 2023
| @@ -44,3 +54,14 @@ def is_sdk_frame(self, frame: Mapping[str, Any]) -> bool: | |||
| return True | |||
|
|
|||
| return False | |||
|
|
|||
| def is_system_library_frame(self, frame: Mapping[str, Any]) -> bool: | |||
There was a problem hiding this comment.
I moved this function from event_stripper to there.
iker-barriocanal
approved these changes
Jul 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52119 +/- ##
=======================================
Coverage 79.31% 79.31%
=======================================
Files 4901 4901
Lines 205111 205123 +12
Branches 35063 35065 +2
=======================================
+ Hits 162689 162702 +13
- Misses 37460 37462 +2
+ Partials 4962 4959 -3
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seems huge, with almost 300 additions, but around 150 are test case stacktrace frame data.
This PR adds a test case with frames from a real-world crash caused by our MetricKit integration. All data was anonymized. While adding the test case, a couple of problems surfaced that this PR addresses: