-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(sdk-crashes): Improve Cocoa crash detection (#52119)
This PR adds a test case with frames from a real-world crash caused by our MetricKit integration. All data was anonymized. While adding the test case, a couple of problems surfaced that this PR addresses: 1. Correctly detect crashes from Swift files starting with SentryMX. 2. Correctly detect crashes from class extensions such as NSDate(SentryExtras). 3. Ignore in_app when detecting an SDK crash, as customers can change the in_app rules. Furthermore, if they use static linking for including Sentry Cocoa, Cocoa SDK frames can be marked as in_app. Instead, the algorithm only checks if frames are SDK frames or from system libraries.
- Loading branch information
1 parent
856c373
commit e110e46
Showing
4 changed files
with
283 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.