Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disables onCodeChanges() method on language update #3129 #3130

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Disables onCodeChanges() method on language update #3129 #3130

merged 1 commit into from
Feb 1, 2021

Conversation

afbora
Copy link
Member

@afbora afbora commented Jan 30, 2021

Describe the PR

LanguageUpdateDialog was using the LanguageCreateDialog mixin. I have disabled onCodeChanges() method with override.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Added in-code documentation (if needed)
  • CI passes (runs automatically when the PR is created or run composer ci locally)
    Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.

@afbora afbora added this to the 3.5.2 milestone Jan 30, 2021
@afbora afbora self-assigned this Jan 30, 2021
@afbora afbora linked an issue Jan 30, 2021 that may be closed by this pull request
[Panel] PHP locale string is incorrect #3129
Closed
@bastianallgeier bastianallgeier merged commit 5cd90d1 into develop Feb 1, 2021
@bastianallgeier bastianallgeier deleted the fix/3129-incorrect-language-locale branch February 1, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@distantnative distantnative Awaiting requested review from distantnative

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

[Panel] PHP locale string is incorrect
2 participants
@afbora @bastianallgeier