Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] PHP locale string is incorrect #3129

Closed
ghost opened this issue Jan 30, 2021 · 1 comment · Fixed by #3130
Closed

[Panel] PHP locale string is incorrect #3129

ghost opened this issue Jan 30, 2021 · 1 comment · Fixed by #3130
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@ghost
Copy link

ghost commented Jan 30, 2021

Describe the bug
Just created my first (default) language in the Panel: English.

PHP locale string is set to en_US by default, so I changed it to en_GB. The new locale string is set correctly in the file site/languages/en.php, but after reloading the Panel, PHP locale string is reset to en_US (only there, not in the file).

To Reproduce
Steps to reproduce the behavior:

  1. Enable languages in site/config/config.php
  2. Go to the Panel > Settings
  3. Create the first language: English (all fields automatically fill in corresponding values, including en_US)
  4. Change en_US to en_GB and add the language
  5. Edit the newly created language, it says en_US now.
  6. Go to site/languages/en.php, the value LC_ALL is set to en_GB.

Expected behavior
The Panel should display the correct locale string.

Screenshots
Panel
File

Kirby Version
3.5.1

Console output
No output.

Desktop

  • OS: macOS
  • Browser: Safari
  • Version: 14.0
@afbora afbora self-assigned this Jan 30, 2021
@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Jan 30, 2021
@afbora afbora added this to the 3.5.2 milestone Jan 30, 2021
@afbora afbora linked a pull request Jan 30, 2021 that will close this issue
4 tasks
bastianallgeier added a commit that referenced this issue Feb 1, 2021
…cale

Disables `onCodeChanges()` method on language update #3129
@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants