Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Extension list does not get updated correctly #210

Closed
cnmarco opened this issue Jun 23, 2022 · 0 comments · Fixed by #212
Closed

[BUG]: Extension list does not get updated correctly #210

cnmarco opened this issue Jun 23, 2022 · 0 comments · Fixed by #212

Comments

@cnmarco
Copy link
Contributor

cnmarco commented Jun 23, 2022

Once table 'tx_t3monitoring_domain_model_extension' is filled, T3Monitor\T3monitoring\Service\Import\ExtensionImport::insertExtensionsInCustomTable() does not get called.
As far as I understand, this method only gets called when T3Monitor\T3monitoring\Service\Import\ExtensionImport::updateExtensionList() has returned true before. That method, however, can not return true, because it depends on a boolean return value of a core mehtod which in fact returns void.

georgringer pushed a commit that referenced this issue Jun 23, 2022
* Fix updating extension list and resetting state "is_latest" for extensions

* Minor code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant