[BUGFIX] #210 and #211 (#212)

* Fix updating extension list and resetting state "is_latest" for extensions * Minor code cleanup
georgringer · Jun 23, 2022 · 2ff2283 · 2ff2283
1 parent 00c97a8
commit 2ff2283
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/Classes/Service/DataIntegrity.php b/Classes/Service/DataIntegrity.php
@@ -154,6 +154,13 @@ protected function getLatestExtensionVersion()
                 ->execute();
         }
 
+        // set is_latest = 0 for extension versions that are not last_major_release
+        $queryBuilder = $connection->createQueryBuilder();
+        $queryBuilder->update($table)
+            ->set('is_latest', 0)
+            ->where('version != last_major_release')
+            ->execute();
+
         $queryBuilder = $connection->createQueryBuilder();
         $queryBuilder->update($table)
             ->set('is_latest', 1)

diff --git a/Classes/Service/Import/ExtensionImport.php b/Classes/Service/Import/ExtensionImport.php
@@ -32,7 +32,9 @@ class ExtensionImport extends BaseImport
      */
     public function run()
     {
-        $updateRequired = $this->updateExtensionList();
+        // $updateRequired = $this->updateExtensionList();
+        // always set $updateRequired = true, as $this->updateExtensionList() never returns true
+        $updateRequired = true;
         if ($updateRequired) {
             $this->insertExtensionsInCustomTable();
         }
@@ -137,6 +139,8 @@ protected function updateExtensionList(): bool
 
         $remoteRegistry = GeneralUtility::makeInstance(RemoteRegistry::class);
         foreach ($remoteRegistry->getListableRemotes() as $remote) {
+            // TYPO3 11.5.12: at least TYPO3\CMS\Extensionmanager\Remote\TerExtensionRemote::getAvailablePackages()
+            // returns void, so $updated will never become TRUE here...
             $remoteUpdate = $remote->getAvailablePackages();
             if ($remoteUpdate) {
                 $updated = true;