Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lorem ipsum generator #455

Merged
merged 1 commit into from
Jan 9, 2019
Merged

add lorem ipsum generator #455

merged 1 commit into from
Jan 9, 2019

Conversation

klaxon1
Copy link
Contributor

@klaxon1 klaxon1 commented Dec 28, 2018

To resolve: #421

Lorem Ipsum placeholder text can be generated at different lengths, based on: paragraph, sentence, work or byte length.
The text always begins with Lorem ipsum dolor sit amet so that it is easily recognisable.

i haven't written an tests for this operation as im not sure how to test the randomly generated outputs.

@n1474335
Copy link
Member

Excellent. I'll take a proper look through when I get some time but at a quick glance this looks very good.

You can use expectedMatch along with a regular expression to test outputs that you can't predict exactly. You could potentially add a test that makes sure the output starts with "Lorem ipsum dolor sit amet" if you like, although it would be of limited use! Perhaps something that ensures there are the correct number of newlines would be more appropriate.

@n1474335 n1474335 merged commit f2d115e into gchq:master Jan 9, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 8, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 16, 2022
Open
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🛂 Adds access control checks in editor forms (gchq#455)
c8ad80b
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🛂 Adds warning msg, for when config disabled (gchq#455)
20f231c
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🛂 Remove edit from context menu, if no permissions (gchq#455)
0146e99
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🛂 Remove start edditing button, if no permissions (gchq#455)
ca9498b
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🛂 Prevent download config when (gchq#455)
c1607cb
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
@Lissy93
🔀 Merge pull request gchq#488 from Lissy93/FIX/general-issues
23f2c1a 
[FIX] General issues and improvements
Fixes gchq#452
Fixes gchq#454
Fixes gchq#455
Fixes gchq#463
Fixes gchq#479
Fixes gchq#482
Fixes gchq#483
Fixes gchq#485
Fixes gchq#486
Fixes gchq#487
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
operation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operation request: Lorem Ipsum generator
2 participants
@klaxon1 @n1474335