Rolling xor #452
Open
Rolling xor #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
|
Hi @masq, thanks very much for this PR. I'd rather not add more methods to inbuilt prototypes like Array and String as it can effect performance. Could you modify this so that the functions are standalone and then I will merge it. Thanks! |
…ptions. Not in love with those names though, tbh
… transcribing from old code
mattnotmitt
reviewed
Feb 17, 2024
| ], | ||
| }, | ||
| { op: "To Binary", args: ["Space"] }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Needs some tests for Rolling... schemes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first time contributing to CyberChef, thought I'd just try to implement an extra option to an existing operation. Tried to take a swing at #426. I added a few "Rolling" options, not sure entirely if this accomplishes exactly the requested operation, but it should be a good start.
Please let me know how it is and what else I can do!