Removed excess buttons in entry overview, replacing it with button th… #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at releases a dropdown menu
IR96334
requested review from
ARADDCC012 and
ARADDCC002
and removed request for
ARADDCC012
ARADDCC012
requested changes
Aug 7, 2024
…own-for-thebuttons-on-the-model-overview-page
|
I think it would be nice if we added chevrons to the button so that it points down when closed:
And then like so when it's opened:
I also think the list would like nicer with icons on the left-hand side:
The above example is also using the |
ARADDCC002
requested changes
Aug 8, 2024
| </Button> | ||
| <Button variant='outlined' onClick={() => setHistoryDialogOpen(true)}> | ||
| View History | ||
| <Fragment> |
There was a problem hiding this comment.
<Fragment></Fragment> can be replaced with <></>
| </MenuItem> | ||
| {!readOnly && ( | ||
| <Tooltip title={requiredRolesText}> | ||
| <span> |
There was a problem hiding this comment.
I don't think we need to wrap the <MenuItem /> in a <span />
ARADDCC012
approved these changes
Aug 8, 2024
ARADDCC002
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Approved - but we should wait for #1455 to go in first, then merge those changes into this PR.
ARADDCC002
requested changes
Aug 9, 2024
ARADDCC002
approved these changes
Aug 12, 2024
…-on-the-model-overview-page
ARADDCC012
deleted the
BAI-1408-Add-a-menu/drop-down-for-thebuttons-on-the-model-overview-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at releases a dropdown menu