Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bai 1376 display entry collaborators outside of the settings tab #1455

Merged

Conversation

IR96334
Copy link
Member

@IR96334 IR96334 commented Aug 6, 2024

No description provided.

@IR96334 IR96334 requested review from ARADDCC012 and ARADDCC002 and removed request for ARADDCC012 August 6, 2024 16:20
frontend/src/entry/settings/EntityItem.tsx Show resolved Hide resolved
frontend/src/entry/settings/EntryAccessTab.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/FormEditPage.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryCardRolesDialog.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryCardEntityRoleRow.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryCardEntityRoleRow.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryCardRolesChipSet.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryCardEntityRoleRow.tsx Outdated Show resolved Hide resolved
@IR96334 IR96334 requested a review from ARADDCC012 August 8, 2024 14:11
frontend/src/entry/overview/EntryRolesDialog.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/FormEditPage.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/EntryRoleList.tsx Outdated Show resolved Hide resolved
import { Chip } from '@mui/material'
import { useMemo } from 'react'
import { CollaboratorEntry } from 'types/types'

type EntryCardChipSetProps = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for not noticing this the first time around. Should be EntryCardRolesChipSetProps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

frontend/src/entry/overview/EntryCardEntityRoleRow.tsx Outdated Show resolved Hide resolved
@IR96334 IR96334 dismissed ARADDCC012’s stale review August 12, 2024 14:34

1 review is sufficient

@IR96334 IR96334 merged commit e22f736 into main Aug 12, 2024
14 checks passed
@ARADDCC012 ARADDCC012 deleted the BAI-1376-Display-entry-collaborators-outside-of-the-settings-tab branch August 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants