-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bai 1376 display entry collaborators outside of the settings tab #1455
Merged
IR96334
merged 13 commits into
main
from
BAI-1376-Display-entry-collaborators-outside-of-the-settings-tab
Aug 12, 2024
Merged
Bai 1376 display entry collaborators outside of the settings tab #1455
IR96334
merged 13 commits into
main
from
BAI-1376-Display-entry-collaborators-outside-of-the-settings-tab
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name (typography) and one for variable amount of chips representing the roles assigned to the collaborator
IR96334
requested review from
ARADDCC012 and
ARADDCC002
and removed request for
ARADDCC012
August 6, 2024 16:20
ARADDCC012
requested changes
Aug 7, 2024
ARADDCC012
previously requested changes
Aug 8, 2024
import { Chip } from '@mui/material' | ||
import { useMemo } from 'react' | ||
import { CollaboratorEntry } from 'types/types' | ||
|
||
type EntryCardChipSetProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad for not noticing this the first time around. Should be EntryCardRolesChipSetProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
ARADDCC002
approved these changes
Aug 12, 2024
ARADDCC012
deleted the
BAI-1376-Display-entry-collaborators-outside-of-the-settings-tab
branch
August 14, 2024 15:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.