5 -> 6

[iche033]

➡️ Forward port

Port ign-gazebo5 to ign-gazebo6

Branch comparison: ign-gazebo6...ign-gazebo5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

[iche033]

looks like the changes from #1302 broke the BuoyancyTest.RestoringMoments test in ign-gazebo6. Locally the test fails with this output:

/home/ian/code/ign_f_ws2/src/ign-gazebo/test/integration/buoyancy.cc:159: Failure
The difference between minUniformRoll and -0.15 is 0.10002078209942011, which exceeds 1e-1, where
minUniformRoll evaluates to -0.049979217900579881,
-0.15 evaluates to -0.14999999999999999, and
1e-1 evaluates to 0.10000000000000001.

Maybe @arjo129 has an idea on what causes this failure?

[iche033]

looks like the changes from #1302 broke the BuoyancyTest.RestoringMoments test in ign-gazebo6. Locally the test fails with this output:

I increased the tolerance by a small amount (3e-5) for the test to pass in 756fa13. Let me know if that's not the right thing to do.

[codecov]

Codecov Report

Merging #1322 (a98f044) into ign-gazebo6 (1ef2c62) will decrease coverage by 0.00%.
The diff coverage is 68.60%.

❗ Current head a98f044 differs from pull request most recent head 2b409b0. Consider uploading reports for the commit 2b409b0 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1322      +/-   ##
===============================================
- Coverage        62.05%   62.05%   -0.01%     
===============================================
  Files              278      278              
  Lines            23315    23370      +55     
===============================================
+ Hits             14469    14502      +33     
- Misses            8846     8868      +22     

Impacted Files	Coverage Δ
...clude/ignition/gazebo/components/CenterOfVolume.hh	100.00% <ø> (ø)
...int_position_controller/JointPositionController.cc	71.85% <0.00%> (-2.20%)	⬇️
src/systems/air_pressure/AirPressure.cc	72.15% <69.23%> (-1.09%)	⬇️
src/systems/altimeter/Altimeter.cc	72.83% <69.23%> (-1.14%)	⬇️
src/systems/logical_camera/LogicalCamera.cc	74.41% <69.23%> (-1.23%)	⬇️
src/systems/magnetometer/Magnetometer.cc	70.11% <69.23%> (-0.78%)	⬇️
src/systems/imu/Imu.cc	71.73% <71.42%> (-0.88%)	⬇️
src/systems/thruster/Thruster.cc	90.26% <75.00%> (-1.82%)	⬇️
src/systems/buoyancy/Buoyancy.cc	82.52% <100.00%> (-0.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef2c62...2b409b0. Read the comment docs.

[arjo129]

Tested this and seems to work. LGTM.