Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit thruster system's input thrust cmd #1318

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Limit thruster system's input thrust cmd #1318

merged 3 commits into from
Feb 4, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 2, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🎉 New feature

Summary

Add two new params to the thruster system for configuring the min and max input thrust cmd:

  • <max_thrust_cmd>
  • <min_thrust_cmd>

This affects both PID and vel controlled thrusters.

Test it

Run the INTEGRATION_thruster test

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 2, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about cheking if min is bigger than max ? Otherwise LGTM

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor Author

iche033 commented Feb 4, 2022

what do you think about cheking if min is bigger than max ?

added check in d795d00

@iche033 iche033 merged commit 986e30f into ign-gazebo5 Feb 4, 2022
@iche033 iche033 deleted the limit_thrust branch February 4, 2022 01:41
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@scpeters
Copy link
Member

scpeters commented Mar 3, 2022

I just tried merging this forward to main and I see some conflicts with #1269

@scpeters
Copy link
Member

scpeters commented Mar 3, 2022

I just tried merging this forward to main and I see some conflicts with #1269

never mind there is already a merge-forward PR in #1367, but I think it also is struggling with these conflicts

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants