Skip to content

Commit

Permalink
fix buoyancy test by increasing tol
Browse files Browse the repository at this point in the history
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
  • Loading branch information
iche033 committed Feb 4, 2022
1 parent 6ec4ae2 commit 756fa13
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/integration/buoyancy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ TEST_F(BuoyancyTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(RestoringMoments))
EXPECT_NEAR(maxUniformRoll, 0.11, 1e-1);
EXPECT_NEAR(minUniformRoll, minGradedRoll, 1e-1);
// Emperically derived
EXPECT_NEAR(minUniformRoll, -0.15, 1e-1);
// added extra tol (3e-5) after fixing center of volume's reference frame
EXPECT_NEAR(minUniformRoll, -0.15, 1e-1 + 3e-5);
}

/////////////////////////////////////////////////
Expand Down

1 comment on commit 756fa13

@arjo129
Copy link
Contributor

@arjo129 arjo129 commented on 756fa13 Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm 3e-5 radians is 0.0017 degrees. I wouldn't bother much about it as it is likely from floating point error.

Please sign in to comment.