-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform to ros format for header field frame_id of sensor msgs #195
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-sensors3 #195 +/- ##
================================================
+ Coverage 77.48% 77.57% +0.09%
================================================
Files 23 23
Lines 2367 2377 +10
================================================
+ Hits 1834 1844 +10
Misses 533 533
Continue to review full report at Codecov.
|
f6fa433
to
858c394
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
…ame_id Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Not sure what's wrong with the sensors windows CI build. I just retriggered a new build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green now
…osim#195) Signed-off-by: ahcorde <ahcorde@gmail.com>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
Is it possible to trigger a release of |
Hello, |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Saw this now only. I tried |
🎉 New feature
Summary
While I was giving support for the turtlebot3 in Ignition , I found that the
frame_id
is generated with this format<model_name>::<link_name>::<sensor_bane>
, then when we use the bridge to republish the data in the ROS network, theframe_id
is modified here and it will look like<model_name>/<link_name>/<sensor_bane>
, but this format is still not valid, it not matching with anyframe_id
intf
.This PR overwrite the
frame_id
value and set it to another value which allows to make it compatible with ROS.I don't know where is the right place to document this.
Test it
Following the steps in the other PR you can test this.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.