Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-rendering6 ➡️ gz-rendering7 #921

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 26, 2023

➡️ Forward port

Port ign-rendering6 ➡️ gz-rendering7

Branch comparison: gz-rendering7...ign-rendering6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 5 commits June 12, 2023 17:48
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
…#905)

* Calculate camera intrinsics : Refactor gazebosim#700 (gazebosim#755)


Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from iche033 as a code owner September 26, 2023 04:40
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #921 (a0f432b) into gz-rendering7 (da675f6) will not change coverage.
The diff coverage is n/a.

❗ Current head a0f432b differs from pull request most recent head c896a9a. Consider uploading reports for the commit c896a9a to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #921   +/-   ##
==============================================
  Coverage          77.22%   77.22%           
==============================================
  Files                170      170           
  Lines              14721    14721           
==============================================
  Hits               11369    11369           
  Misses              3352     3352           

@azeey
Copy link
Contributor Author

azeey commented Sep 26, 2023

@Crola1702 it looks like the windows job started failing on https://build.osrfoundation.org/view/ign-garden/job/ign_rendering-gz-7-win/80/ with no change in the code. There might be something wrong with how the CI machines are configured. Can you look into it?

@azeey azeey merged commit 1876bc6 into gazebosim:gz-rendering7 Sep 26, 2023
8 of 9 checks passed
@azeey azeey deleted the 6_to_7 branch September 26, 2023 20:54
@Crola1702
Copy link
Contributor

@Crola1702 it looks like the windows job started failing on https://build.osrfoundation.org/view/ign-garden/job/ign_rendering-gz-7-win/80/ with no change in the code. There might be something wrong with how the CI machines are configured. Can you look into it?

This is: #745. It has been happening consistently in the last month. I'll take a look

@Crola1702
Copy link
Contributor

AFAIK, we don't have a lot of control over SEH exceptions. I checked on the internet and found a bit of information about those (link)

@azeey
Copy link
Contributor Author

azeey commented Sep 27, 2023

AFAIK, we don't have a lot of control over SEH exceptions. I checked on the internet and found a bit of information about those (link)

Thanks, I'll respond on the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants