Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DEM support to heightmaps #315

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Added DEM support to heightmaps #315

merged 4 commits into from
Mar 15, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Dec 16, 2021

🎉 New feature

Summary

Extended heightmap implementation to support DEMs.

ign-gazebo preview:
Peek 2021-12-15 19-14

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added the DART DART engine label Dec 16, 2021
@chapulina
Copy link
Contributor

@jennuine jennuine mentioned this pull request Dec 21, 2021
8 tasks
@chapulina chapulina added the 🌱 garden Ignition Garden label Dec 30, 2021
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #315 (ecf8013) into main (5a5a974) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ecf8013 differs from pull request most recent head f299b26. Consider uploading reports for the commit f299b26 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   75.61%   75.65%   +0.03%     
==========================================
  Files         128      128              
  Lines        5541     5537       -4     
==========================================
- Hits         4190     4189       -1     
+ Misses       1351     1348       -3     
Impacted Files Coverage Δ
...clude/ignition/physics/heightmap/HeightmapShape.hh 100.00% <ø> (ø)
dartsim/src/CustomHeightmapShape.cc 94.73% <100.00%> (+12.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5a974...f299b26. Read the comment docs.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@scpeters
Copy link
Member

CI is giving warnings because it is not using gazebosim/gz-common#292

@azeey azeey removed their request for review March 1, 2022 15:20
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Mar 1, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@chapulina
Copy link
Contributor

Windows CI is broken on main. Not blocking this because of that, merging.

https://build.osrfoundation.org/job/ign_physics-ci-win/147/console

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(997,5): error MSB6006: "link.exe" exited with code -1073741571. [C:\Jenkins\workspace\ign_physics-ci-win\ws\build\ignition-physics6\test\integration\INTEGRATION_FrameSemantics3f.vcxproj]

@chapulina chapulina merged commit ba10632 into main Mar 15, 2022
@chapulina chapulina deleted the jennuine/dem branch March 15, 2022 16:43
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DART DART engine 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants