Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync script for translation repos #21185

Merged
merged 72 commits into from
Feb 28, 2020
Merged

Sync script for translation repos #21185

merged 72 commits into from
Feb 28, 2020

Conversation

tesseralis
Copy link
Contributor

@tesseralis tesseralis commented Feb 4, 2020

Description

Create a sync script that updates translation repositories based on the current state of the source repo.

Usage:

yarn run sync [language code]

Behavior

  1. Creates a new PR that merges the source repo gatsby-i18n-source to the current head of the translation repo, committing all merge conflicts
  2. Adds comments referring to the changes in the source between the last sync and now, to help translators decide what content needs to be updated.

Next steps

  • Don't create a PR if there is an existing one
  • Watch source repo and run on all translation repos when there are updates
  • Automatically merge the PR if there are no conflicts
  • Documentation for how to resolve a sync script (pending (docs) Split translation guide into multiple pages for clarity #21254)
  • Decide if we want to commit non-conflicting files separately

Examples

Documentation

#21753

Related issues

Fixes: #21250

@AishaBlake
Copy link

@tesseralis this looks good and I've seen it work. I've also read through the WIP docs in #21753. Do you intend to work on any more of the "next steps" in this PR or do you feel comfortable moving forward? I think I'd prefer to merge with the functionality this has now and then work in smaller chunks to tackle additional work.

@tesseralis
Copy link
Contributor Author

@AishaBlake I'd like to merge this in now and work on the "next steps" in a different PR.

AishaBlake
AishaBlake previously approved these changes Feb 27, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this and ready to merge.

@AishaBlake
Copy link

Should probably also check in with @LekoArts. Lennart, feel free to merge if you're good with this! I'd also like to get #21753 in soon after.

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Seem like the checks fail though)

@tesseralis
Copy link
Contributor Author

@LekoArts it's only starters validate, it's failing because of npm audits.

@tesseralis tesseralis merged commit 136a6df into gatsbyjs:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(scripts/i18n) Create a script to sync translation repos
5 participants