Validate first_step and max_accel parameters values in login_solve and related functions
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusimeon
changed the title
first_step and max_accel parameters values in login_solveand related functionsfirst_step and max_accel parameters values in login_solve and related functions
|
Thank you for this. Could you also please consider adding a few tests to check these, and also to check the Also, while you are at it, the function names quoted in |
…ve` and related functions
lusimeon
force-pushed
the
459-validate-logit_solve-parameters
branch
from
aeb1829
to
8ab08a9
Compare
|
Hi, thank you for your feedback. I've added tests to checks parameters, and correct the mispelled functions names. Seems good for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #459