Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid values of path-following parameters in logit_solve and related functions #459

Open
tturocy opened this issue Jun 12, 2024 · 1 comment
Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python
Milestone

Comments

@tturocy
Copy link
Member

tturocy commented Jun 12, 2024

We have recently exposed some of the algorithm parameters for controlling the numerical continuation in logit_solve, logit_solve_lambda, and logit_solve_branch. At the moment these aren't being checked for being valid values. The initial step length should be positive, and the acceleration factor should always be at least one.

@tturocy tturocy added good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python labels Jun 12, 2024
@tturocy tturocy added this to the gambit-16.3.0 milestone Jun 12, 2024
@ankur-kalita
Copy link

heyy @tturocy can you assign this issue to me ?... i am working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python
Projects
None yet
Development

No branches or pull requests

2 participants