Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 16 to 17 #15

Closed
wants to merge 1 commit into from
Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 1, 2021

Bumps node from 16 to 17.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps node from 16 to 17.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Nov 1, 2021
@DasSkelett DasSkelett mentioned this pull request Nov 1, 2021
@DasSkelett
Copy link
Member

Error: error:0308010C:digital envelope routines::unsupported
  at new Hash (node:internal/crypto/hash:67:19)
  at Object.createHash (node:crypto:130:10)
  at module.exports (/code/node_modules/webpack/lib/util/createHash.js:135:53)
  at NormalModule._initBuildHash (/code/node_modules/webpack/lib/NormalModule.js:417:16)
  at /code/node_modules/webpack/lib/NormalModule.js:452:10
  at /code/node_modules/webpack/lib/NormalModule.js:323:13
  at /code/node_modules/loader-runner/lib/LoaderRunner.js:367:11
  at /code/node_modules/loader-runner/lib/LoaderRunner.js:233:18
  at context.callback (/code/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
  at /code/node_modules/babel-loader/lib/index.js:59:103 {
    opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
    library: 'digital envelope routines',
    reason: 'unsupported',
    code: 'ERR_OSSL_EVP_UNSUPPORTED'
  }

https://medium.com/the-node-js-collection/node-js-17-is-here-8dba1e14e382#5f07

If you hit an ERR_OSSL_EVP_UNSUPPORTED error in your application with Node.js 17, it’s likely that your application or a module you’re using is attempting to use an algorithm or key size which is no longer allowed by default with OpenSSL 3.0. A new command-line option, --openssl-legacy-provider, has been added to revert to the legacy provider as a temporary workaround for these tightened restrictions.

webpack/webpack#14532

We will not update that in webpack 4.
this has been fixed with release v5.61.0.

However we are still at 4.42.0, and

The webpack dependency comes through react-scripts::

$ npm list webpack
website@ wg-access-server/website
└─┬ react-scripts@3.4.3
  ├─┬ babel-loader@8.1.0
  │ └── webpack@4.42.0 deduped
  ├─┬ css-loader@3.4.2
  │ └── webpack@4.42.0 deduped
  ├─┬ eslint-loader@3.0.3
  │ └── webpack@4.42.0 deduped
  ├─┬ file-loader@4.3.0
  │ └── webpack@4.42.0 deduped
  ├─┬ html-webpack-plugin@4.0.0-beta.11
  │ └── webpack@4.42.0 deduped
  ├─┬ mini-css-extract-plugin@0.9.0
  │ └── webpack@4.42.0 deduped
  ├─┬ optimize-css-assets-webpack-plugin@5.0.3
  │ └── webpack@4.42.0 deduped
  ├─┬ sass-loader@8.0.2
  │ └── webpack@4.42.0 deduped
  ├─┬ terser-webpack-plugin@2.3.8
  │ └── webpack@4.42.0 deduped
  ├─┬ url-loader@2.3.0
  │ └── webpack@4.42.0 deduped
  ├─┬ webpack-dev-server@3.11.0
  │ ├─┬ webpack-dev-middleware@3.7.3
  │ │ └── webpack@4.42.0 deduped
  │ └── webpack@4.42.0 deduped
  ├─┬ webpack-manifest-plugin@2.2.0
  │ └── webpack@4.42.0 deduped
  ├─┬ webpack@4.42.0
  │ └─┬ terser-webpack-plugin@1.4.5
  │   └── webpack@4.42.0 deduped
  └─┬ workbox-webpack-plugin@4.3.1
    └── webpack@4.42.0 deduped

Bug report: facebook/create-react-app#11562

While we seem to be a bit behind on react-scripts versions (why does dependabot not offer an update there? Did it only do security updates in the first run?), updating to the latest version wouldn't fix it yet. There is a PR open to update the webpack dependency in react-scripts which needs to be merged and released first: facebook/create-react-app#11597

In the meantime, we could either add this --openssl-legacy-provider option workaround, but a user reoprted that this would break Node 16 installations, and I'd like to keep backwards compatibility to at least that one (it's the newest big LTS release).

We could set the environment variable in the Dockerfile, but for now I'd prefer to stay on Node 16 instead. Node 17 is still pretty young, there could be other hidden bugs as well. Let's give projects some time to update.

@DasSkelett DasSkelett closed this Nov 1, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Nov 1, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/docker/node-17 branch November 1, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant