Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #11597

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Update package.json #11597

merged 2 commits into from
Nov 1, 2021

Conversation

HADMARINE
Copy link
Contributor

@HADMARINE HADMARINE commented Oct 29, 2021

Bump webpack version to 5.61.0
Resolution of #11595

Issue has been caused by webpack, and it was resolved in [v5.61.0].(https://github.com/webpack/webpack/releases/tag/v5.61.0)

Bump webpack version to 5.61.0
Resolution of facebook#11595
@HADMARINE HADMARINE requested a review from iansu as a code owner October 29, 2021 14:10
@facebook-github-bot
Copy link

Hi @HADMARINE!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@HADMARINE
Copy link
Contributor Author

HADMARINE commented Nov 1, 2021

We need to test this version on node 17 to verify that is really resolved, can you add some CI pipeline of latest node?

@iansu
Copy link
Contributor

iansu commented Nov 1, 2021

Thanks! This works with our current tests so I'm going to merge it. I've got another branch where I'm upgrading our CI to use Node 17.

@iansu iansu merged commit 544befe into facebook:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants