fix: return type of get_party_details
#43131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
barredterra
changed the title
get_party_details
barredterra
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 1bb2745)
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 1bb2745)
This was referenced Sep 9, 2024
barredterra
added a commit
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> fix: return type of `get_party_details` (#43131)
barredterra
added a commit
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> fix: return type of `get_party_details` (#43131)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
# [14.74.0](v14.73.2...v14.74.0) (2024-09-11) ### Bug Fixes * `default_advance_account` field in Process Payment Reconciliation ([3691a50](3691a50)) * bom cost update is not working (backport [#43155](#43155)) ([#43156](#43156)) ([9110534](9110534)) * cancel common party advance jv while canceling the invoice ([f506952](f506952)) * check multi-currency on jv for common party accounting with foreign currency ([a3a40fe](a3a40fe)) * **Delivery Note:** translatability of validation errors ([5e33961](5e33961)) * incorrect actual cost in Procurement Tracker report (backport [#43109](#43109)) ([#43137](#43137)) ([a4b9dda](a4b9dda)) * incorrect qty after transaction in SLE (backport [#43103](#43103)) ([#43104](#43104)) ([77892f4](77892f4)) * return type of `get_party_details` (backport [#43131](#43131)) ([#43135](#43135)) ([e8aae50](e8aae50)) * set today in 'On This Date' in Available Batch Report ([36f65fc](36f65fc)) * uncomment internal parties ([4dd06b6](4dd06b6)) * unreconcile allocation child table redirect url voucher no issue ([53496ed](53496ed)) ### Features * utility report to identify invalid ledger entries ([37b8715](37b8715))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
# [15.35.0](v15.34.2...v15.35.0) (2024-09-11) ### Bug Fixes * `default_advance_account` field in Process Payment Reconciliation ([75cb298](75cb298)) * bom cost update is not working (backport [#43155](#43155)) ([#43157](#43157)) ([8c8dc24](8c8dc24)) * cancel common party advance jv while canceling the invoice ([9bd3d7a](9bd3d7a)) * Cannot read properties of null (reading 'doc') (backport [#43071](#43071)) ([#43118](#43118)) ([80b5c16](80b5c16)) * check multi-currency on jv for common party accounting with foreign currency ([d17badd](d17badd)) * concurrency issue while picking materials (backport [#43087](#43087)) ([#43152](#43152)) ([cd57e00](cd57e00)) * **Delivery Note:** translatability of validation errors ([ea4f736](ea4f736)) * ensure `SellingController.onload` gets called for SO & DN ([2c1f72e](2c1f72e)) * incorrect actual cost in Procurement Tracker report (backport [#43109](#43109)) ([#43138](#43138)) ([5110975](5110975)) * incorrect qty after transaction in SLE (backport [#43103](#43103)) ([#43105](#43105)) ([8447bf3](8447bf3)) * **minor:** reorder expected value validation ([6fde07d](6fde07d)) * multiple fixes related to remarks for GL Report ([#42753](#42753)) ([f45b1db](f45b1db)) * **Opening Invoice Creation Tool:** translatability of messages ([3fd9df0](3fd9df0)) * pass company from asset to asset capitalization ([9e72a84](9e72a84)) * permission on guest PR creation ([a23e8b1](a23e8b1)) * return type of `get_party_details` (backport [#43131](#43131)) ([#43134](#43134)) ([d2923ba](d2923ba)) * set today in 'On This Date' in Available Batch Report ([03e3374](03e3374)) * uncomment internal parties ([33174b1](33174b1)) * unhide action button after form redirect ([208bd2b](208bd2b)) * unreconcile allocation child table redirect url voucher no issue ([2dddd79](2dddd79)) * validate the item code when updating the other item's price rule ([8f4dc80](8f4dc80)) ### Features * added revaluation surplus and impairment acc in standard charts… ([#43022](#43022)) ([ea86bc2](ea86bc2)) * utility report to identify invalid ledger entries ([5929d50](5929d50)) ### Performance Improvements * timeout error (backport [#43154](#43154)) ([#43158](#43158)) ([c9f49ca](c9f49ca))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_party_detailsshould always return afrappe._dict, otherwise it's prone to errors.