Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect actual cost in Procurement Tracker report #43109

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue
Screenshot 2024-09-08 at 8 32 57 AM

After Fix
Screenshot 2024-09-08 at 8 32 41 AM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 8, 2024
@rohitwaghchaure rohitwaghchaure added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Sep 8, 2024
@rohitwaghchaure rohitwaghchaure merged commit 80f101f into frappe:develop Sep 9, 2024
13 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 9, 2024
mergify bot pushed a commit that referenced this pull request Sep 9, 2024
rohitwaghchaure added a commit that referenced this pull request Sep 9, 2024
…3109) (#43138)

fix: incorrect actual cost in Procurement Tracker report (#43109)

(cherry picked from commit 80f101f)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Sep 9, 2024
…3109) (#43137)

fix: incorrect actual cost in Procurement Tracker report (#43109)

(cherry picked from commit 80f101f)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Sep 11, 2024
# [14.74.0](v14.73.2...v14.74.0) (2024-09-11)

### Bug Fixes

* `default_advance_account` field in Process Payment Reconciliation ([3691a50](3691a50))
* bom cost update is not working (backport [#43155](#43155)) ([#43156](#43156)) ([9110534](9110534))
* cancel common party advance jv while canceling the invoice ([f506952](f506952))
* check multi-currency on jv for common party accounting with foreign currency ([a3a40fe](a3a40fe))
* **Delivery Note:** translatability of validation errors ([5e33961](5e33961))
* incorrect actual cost in Procurement Tracker report (backport [#43109](#43109)) ([#43137](#43137)) ([a4b9dda](a4b9dda))
* incorrect qty after transaction in SLE (backport [#43103](#43103)) ([#43104](#43104)) ([77892f4](77892f4))
* return type of `get_party_details` (backport [#43131](#43131)) ([#43135](#43135)) ([e8aae50](e8aae50))
* set today in 'On This Date' in Available Batch Report ([36f65fc](36f65fc))
* uncomment internal parties ([4dd06b6](4dd06b6))
* unreconcile allocation child table redirect url voucher no issue ([53496ed](53496ed))

### Features

* utility report to identify invalid ledger entries ([37b8715](37b8715))
frappe-pr-bot pushed a commit that referenced this pull request Sep 11, 2024
# [15.35.0](v15.34.2...v15.35.0) (2024-09-11)

### Bug Fixes

* `default_advance_account` field in Process Payment Reconciliation ([75cb298](75cb298))
* bom cost update is not working (backport [#43155](#43155)) ([#43157](#43157)) ([8c8dc24](8c8dc24))
* cancel common party advance jv while canceling the invoice ([9bd3d7a](9bd3d7a))
* Cannot read properties of null (reading 'doc') (backport [#43071](#43071)) ([#43118](#43118)) ([80b5c16](80b5c16))
* check multi-currency on jv for common party accounting with foreign currency ([d17badd](d17badd))
* concurrency issue while picking materials (backport [#43087](#43087)) ([#43152](#43152)) ([cd57e00](cd57e00))
* **Delivery Note:** translatability of validation errors ([ea4f736](ea4f736))
* ensure `SellingController.onload` gets called for SO & DN ([2c1f72e](2c1f72e))
* incorrect actual cost in Procurement Tracker report (backport [#43109](#43109)) ([#43138](#43138)) ([5110975](5110975))
* incorrect qty after transaction in SLE (backport [#43103](#43103)) ([#43105](#43105)) ([8447bf3](8447bf3))
* **minor:** reorder expected value validation ([6fde07d](6fde07d))
* multiple fixes related to remarks for GL Report ([#42753](#42753)) ([f45b1db](f45b1db))
* **Opening Invoice Creation Tool:** translatability of messages ([3fd9df0](3fd9df0))
* pass company from asset to asset capitalization ([9e72a84](9e72a84))
* permission on guest PR creation ([a23e8b1](a23e8b1))
* return type of `get_party_details` (backport [#43131](#43131)) ([#43134](#43134)) ([d2923ba](d2923ba))
* set today in 'On This Date' in Available Batch Report ([03e3374](03e3374))
* uncomment internal parties ([33174b1](33174b1))
* unhide action button after form redirect ([208bd2b](208bd2b))
* unreconcile allocation child table redirect url voucher no issue ([2dddd79](2dddd79))
* validate the item code when updating the other item's price rule ([8f4dc80](8f4dc80))

### Features

* added revaluation surplus and impairment acc in standard charts… ([#43022](#43022)) ([ea86bc2](ea86bc2))
* utility report to identify invalid ledger entries ([5929d50](5929d50))

### Performance Improvements

* timeout error (backport [#43154](#43154)) ([#43158](#43158)) ([c9f49ca](c9f49ca))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant