-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL 8.0 Migration #20225
Merged
Merged
MySQL 8.0 Migration #20225
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9ab43fe
First attempt to upgrade to mysql 8
dantecatalfamo e267482
Don't need patch version, none of the other tests have it
dantecatalfamo db757fb
Update dev docs for 8.0
dantecatalfamo 6e9ba59
Add changes
dantecatalfamo c257754
`make dump-test-schema`
dantecatalfamo 99a8092
No-op commit
dantecatalfamo fb2e521
Pushing another no-op
dantecatalfamo fde27c3
Merge branch 'main' into mysql-8.0
dantecatalfamo fceb3de
Run `go run ./tools/dbutils ./server/datastore/mysql/schema.sql`
dantecatalfamo d14e785
Merge branch 'main' into mysql-8.0
dantecatalfamo 2071a8d
Run `go run ./tools/dbutils ./server/datastore/mysql/schema.sql`
dantecatalfamo 6785a51
Merge branch 'main' into mysql-8.0
dantecatalfamo 96d7457
Match CI and docker-compose
dantecatalfamo 4165143
Match mysql versions
dantecatalfamo 828768a
Match version numbers
dantecatalfamo daa08dd
Match version numbers
dantecatalfamo 8b65e03
Match version numebrs
dantecatalfamo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
* Drop support for MySQL 5.7 | ||
* Minimum requirements raised to MySQL 8.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the 8.0 upgrade, Aurora should be spec'd as "version 3" in general, or >= 3.07.0 specifically as that version is the first one with 8.0.36 compat (current version as of writing this is 3.07.1, so you can't go any later than 8.0.36).
Source: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html
This is another reason for not going past 8.0.36 at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this @iansltx. I've opened #21130.