MySQL 8.0 Migration #20225
MySQL 8.0 Migration #20225
Conversation
|
The macos test is failing because I broke the test by fixing a separate bug. That test is fixed here |
dantecatalfamo
requested review from
roperzh,
lukeheath,
georgekarrv,
sharon-fdm,
lucasmrod and
rachaelshaw
as code owners
|
@rachaelshaw Should I hold off merging this until the website updates are ready as well to keep everything in sync? |
There was a problem hiding this comment.
@dantecatalfamo spoke too soon. I think we also need to run make dump-test-schema with a MySQL 8 database and commit the result.
I would have expected the "db changes" test to fail too, so there might be more workflows that need updating?
|
@rfairburn @zayhanlon I want to be extra loud about this change. We are dropping support for MySql 5.7 at Fleet v4.54.0. In October of 2023, MySql 5.7 reached end of life and is no longer receiving security updates. It's very unlikely any of our customers are using it, but we want to make sure any self-hosted customers are aware of this change. |
@roperzh Done! |
|
It looks like our minimum supported version is now Can we replace 5.7 with 8.4? Or is this too much work and requires a separate eng-initiated story? |
|
Hi @getvictor
|
There was a problem hiding this comment.
LGTM, but because no Go file was changed, the complete CI did not run. @dantecatalfamo Could you make a no-op change to a Go file so that the full test suite is executed? It would be a good test before merging the changes.
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
 |
| Ran | Status | Preview | Started | Run time | Est. dev time saved |
|---|---|---|---|---|---|
| 64 workflows | Done (Details) | Visit preview | Jul 23, 2024 at 12:14 PM (UTC) | 40 minutes | ~21.5 hrs |
| 170 workflows | Done (Details) | Visit preview | Jul 23, 2024 at 12:16 PM (UTC) | 17 minutes | ~53.17 hrs |
Latest run
✅ 167 passed
. . . . . . . .
Re-run your E2E tests
| @@ -614,7 +614,7 @@ Yes! Please sign up for the [Fleet Cloud Beta](https://kqphpqst851.typeform.com/ | |||
|
|
|||
| ### What MySQL versions are supported? | |||
|
|
|||
| Fleet is tested with MySQL 5.7.21 and 8.0.28. Newer versions of MySQL 5.7 and MySQL 8 typically work well. AWS Aurora requires at least version 2.10.0. Please avoid using MariaDB or other MySQL variants that are not officially supported. Compatibility issues have been identified with MySQL variants, and these may not be addressed in future Fleet releases. | |||
| Fleet is tested with MySQL 8.0.36. Newer versions of MySQL 8 typically work well. AWS Aurora requires at least version 2.10.0. Please avoid using MariaDB or other MySQL variants that are not officially supported. Compatibility issues have been identified with MySQL variants, and these may not be addressed in future Fleet releases. | |||
There was a problem hiding this comment.
With the 8.0 upgrade, Aurora should be spec'd as "version 3" in general, or >= 3.07.0 specifically as that version is the first one with 8.0.36 compat (current version as of writing this is 3.07.1, so you can't go any later than 8.0.36).
This is another reason for not going past 8.0.36 at the moment.
#17249
This PR handles the
Engineeringportion of the issue to migrate away from MySQL 5.7 towards MySQL 8.0changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.