Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests rely on
etcd
and use theGetClusterHealth
method to ensure the etcd cluster is up and running. In this PR; we upgradedetcd
and it seems now the defaultetcdctl
version is V3.It should fix the following tests:
Note for the reviewers
I first attended to support both v2/v3 but it becomes quickly an unmaintainable mess - so I removed the
setKeys
/checkKeys
from thecl.etcd-member.discovery
. REST APIs from v2 to v3 are not the same at all + v3 APIs between 3.3.35 (current etcd version that we ship) and 3.5 does not have the same prefix neither... Since this check is quite redundant with the others who are usingetcdctl
directly we can safely remove it.How to use
Testing done
cl.etcd-member.discovery
cl.etcd-member.discovery